Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/Sub: Allow kwargs to be passed to create_channel, update templates (via synth). #8399

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Pub/Sub: Allow kwargs to be passed to create_channel, update templates (via synth). #8399

merged 1 commit into from
Jun 18, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/pubsub/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:b036a7f4278d9deb5796f065e5c7f608d47d75369985ca7ab5039998120e972d
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/pubsub/v1/pubsub.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto/pubsub.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'DESCRIPTOR = _MESSAGESTORAGEPOLICY,\n\\s+__module__.*\n\\s+,\n\\s+__doc__ = """' in google/cloud/pubsub_v1/proto/pubsub_pb2.py.
synthtool > No replacements made in google/cloud/pubsub_v1/gapic/subscriber_client.py for pattern subscription \(str\): The subscription whose backlog .*
(.*
)+?\s+Format is .*, maybe replacement is not longer needed?
synthtool > Replaced 'import functools\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'import pkg_resources\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'class PublisherClient' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'client_config \\(dict\\): DEPRECATED.' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# Raise deprecation warnings .*\n.*\n.*\n.*\n.*\n.*\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'FlowControl.__new__.__defaults__ = \\(.*?\\)' in google/cloud/pubsub_v1/types.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in .nox/blacken
pip install black
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/system/gapic/v1/test_system_publisher_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_publisher_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_subscriber_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2.py
All done! ✨ 🍰 ✨
15 files reformatted, 49 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 3 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: pubsub Issues related to the Pub/Sub API. label Jun 18, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
plamut
plamut approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator. Pub/Sub: Allow kwargs to be passed to create_channel (via synth). Jun 18, 2019
@busunkim96 busunkim96 changed the title Pub/Sub: Allow kwargs to be passed to create_channel (via synth). Pub/Sub: Allow kwargs to be passed to create_channel, update templates (via synth). Jun 18, 2019
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2019
@plamut plamut merged commit 0737737 into master Jun 18, 2019
@plamut
Copy link
Contributor

plamut commented Jun 18, 2019 •
edited
Loading

@busunkim96 Huh ... were we supposed to modify the commit message? (or anything else)

It contains that [CHANGE ME] prefix...

@tseaver
Copy link
Contributor

tseaver commented Jun 18, 2019

@plamut Yes, when doing a squash merge of an autogen PR, please copy the relevant title change (less the "Pub/Sub:" prefix) to replace the generated commit message.

@plamut
Copy link
Contributor

plamut commented Jun 18, 2019 •
edited
Loading

I see, my bad. :/ Will keep in mind for the future.

(force-pushing to master with an amended commit message feels wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@busunkim96 busunkim96 busunkim96 left review comments

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yoshi-automation @plamut @tseaver @busunkim96 @googlebot @yoshi-kokoro